Skip to content

Add discussion service to access permission and access provider #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
salman2013 wants to merge 1 commit into
base: salman/extract-discussion-block
Choose a base branch
from
Open

Add discussion service to access permission and access provider #147

salman2013 wants to merge 1 commit into from
+14 −8

Conversation

@salman2013
Copy link
Contributor

@salman2013 salman2013 commented Jan 26, 2026

Description:

Add discussion service config to check discussion permissions and provider settings.

Ticket: openedx/public-engineering#481

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jan 26, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 26, 2026 •
edited
Loading

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 26, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jan 27, 2026
farhan
farhan requested changes Feb 6, 2026
View reviewed changes
Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 improvement, all seems good

xblocks_contrib/discussion/discussion.py Outdated


@XBlock.needs("i18n")
@XBlock.needs("discussion_config_service")
Copy link
Contributor

@farhan farhan Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in other PR, service is optional we should mark it wants rather than needs

@salman2013 salman2013 requested a review from farhan February 10, 2026 10:30
@salman2013 salman2013 marked this pull request as ready for review February 10, 2026 11:37
@salman2013 salman2013 marked this pull request as draft February 10, 2026 11:38
@salman2013 salman2013 force-pushed the salman/discussion-service branch from 04a46f1 to 88a32e8 Compare February 10, 2026 11:59
@salman2013 salman2013 marked this pull request as ready for review February 10, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhan farhan Awaiting requested review from farhan

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Waiting on Author

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@salman2013 @openedx-webhooks @farhan